Skip to content

fix: remove -x from set -euxo pipefail to prevent secret leakage#149

Merged
f-thiele merged 1 commit into
mainfrom
fix/remove-x-from-set-pipefail
Jun 17, 2026
Merged

fix: remove -x from set -euxo pipefail to prevent secret leakage#149
f-thiele merged 1 commit into
mainfrom
fix/remove-x-from-set-pipefail

Conversation

@f-thiele

Copy link
Copy Markdown
Contributor

Summary

Removes the -x flag from set -euxo pipefail to prevent secrets from being printed in GitHub Actions logs.

The -x flag causes bash to print each command before executing it, which can expose secret values that are passed as environment variables or arguments.

Related Issue

Closes SneaksAndData/terraform#7626

Changes

  • Replaced set -euxo pipefail with set -euo pipefail in affected workflow files

@f-thiele f-thiele requested a review from a team as a code owner June 17, 2026 09:39
@f-thiele f-thiele requested review from a team, s-vitaliy and timonviola and removed request for s-vitaliy June 17, 2026 09:39
@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
bootstrap-lk.py131023%6–46, 50
spark_utils/common
   functions.py38489%56, 62, 113, 122
   spark_job_args.py68987%106, 113, 135, 151, 170, 179–183
   spark_session_provider.py832471%60–61, 110, 128, 155, 171, 190–201, 211–281, 294, 310
   spark_sql_utils.py201050%54–63, 79–82
   spark_udf.py4250%36–37
spark_utils/dataframes
   functions.py984851%48, 55–65, 76–78, 93–95, 108–122, 141, 151, 191, 199–202, 211, 230, 246–250, 259–272
spark_utils/dataframes/sets
   functions.py6433%39–42
spark_utils/delta_lake
   delta_log.py17194%52
   functions.py603837%57–67, 97–127, 140–160, 196–197, 200, 220–223
spark_utils/models
   iceberg_rest_config.py21386%51–53
   k8s_config.py18289%18–19
test
   test_iceberg.py23483%12–13, 23–24
   test_spark_session_provider.py24675%11–12, 24–25, 35–36
TOTAL70716577% 

Tests Skipped Failures Errors Time
60 0 💤 0 ❌ 0 🔥 1m 33s ⏱️

@f-thiele f-thiele merged commit 2c3b041 into main Jun 17, 2026
1 check passed
@f-thiele f-thiele deleted the fix/remove-x-from-set-pipefail branch June 17, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants