fix: remove -x from set -euxo pipefail to prevent secret leakage#598
Open
f-thiele wants to merge 2 commits into
Open
fix: remove -x from set -euxo pipefail to prevent secret leakage#598f-thiele wants to merge 2 commits into
f-thiele wants to merge 2 commits into
Conversation
f-thiele
requested review from
a team and
timonviola
and removed request for
a team
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
-xflag fromset -euxo pipefailto prevent secrets from being printed in GitHub Actions logs.The
-xflag causes bash to print each command before executing it, which can expose secret values that are passed as environment variables or arguments.Related Issue
Closes SneaksAndData/terraform#7626
Changes
set -euxo pipefailwithset -euo pipefailin affected workflow files