Thjau/extend snowflake support#584
Draft
ThomasJauho wants to merge 11 commits into
Draft
Conversation
|
marcusforby
reviewed
Apr 9, 2026
marcusforby
left a comment
marcusforby
left a comment
Contributor
There was a problem hiding this comment.
Good iteration - majority looks perfect!
I have some small suggestions, but also some suggested bigger changes to fundamental parts that I think you should consider. Let me know when to have a look again 👍
ThomasJauho
requested review from
a team and
s-vitaliy
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Implemented:
Checklist
.pylintrcwith exceptions.latestcommit.