Open
Conversation
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Closed
Owner
|
This looks fine as-is, but isn't the convention for cmake config files PascalCase? |
|
I think this PR would be a good place to fix #28 ? |
Author
|
I remember I didn't push any further on this because I ended up working on something else. But as it is, I think it can be merged. @grasmanek94 Feel free to test this branch to see if it solves your issue.
I used the convention I've been using for my projects, I honestly don't know if there's a particular convention for cmake config files. @Snaipe If you give me any particular suggestions to the PR I can make amendments. |
ziyao233
pushed a commit
to ziyao233/Mimick
that referenced
this pull request
Feb 9, 2024
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing to use the library in other CMake projects.