Matter Lock: Update Embedded Door Lock cluster#2860
Open
hcarter-775 wants to merge 1 commit intomainfrom
Open
Conversation
hcarter-775
requested review from
HunsupJung,
ctowns,
nickolas-deboom and
tpmanley
|
Invitation URL: |
Test Results 72 files 494 suites 0s ⏱️ Results for commit 263e5d7. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 263e5d7 |
tpmanley
reviewed
Mar 31, 2026
tpmanley
reviewed
Mar 31, 2026
|
|
||
| setmetatable(Feature, new_mt) | ||
|
|
||
| local has_aliases, aliases = pcall(require, "st.matter.clusters.aliases.DoorLock.types.Feature") |
Contributor
There was a problem hiding this comment.
Do we even need this alias code? If so doesn't the path need to be updated?
Contributor
Author
There was a problem hiding this comment.
we do, and the path should not be updated. Without this change tests fail, as some Door Lock feature bits have had their names changed across versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add copyright info to all files.
Add definitions of commands and attributes that are used in the driver.
Add FeatureMap attribute to more cleanly define it.
Add fix to DoorStateEnum attribute.
Summary of Completed Tests