Add more documentation, clean up launchd plist, upgrade dependencies#1
Open
jeffbyrnes wants to merge 14 commits into
Open
Add more documentation, clean up launchd plist, upgrade dependencies#1jeffbyrnes wants to merge 14 commits into
jeffbyrnes wants to merge 14 commits into
Conversation
* launchd agents & daemons are conventionally named in reverse domain format * Move $PATH into the plist * UserName isn’t needed for a User-level launchd agent (i.e., one that goes in ~/Library/LaunchAgents) * StartCalendarInterval obviates StartInterval * Use bash shebang in start.sh to simplify from ProgramArguments to Program
$USERNAME is close enough to $USER (which exists in every macOS shell) to be confusing, this avoids that.
3-space indentation is unusual, this ensures folks abide by it.
Otherwise you get URLs like this:
FetchError: request to https://letterboxd.commovie/ failed
Signed-off-by: Jeff Byrnes <thejeffbyrnes@gmail.com>
- Add LETTERBOXD_USER env var so Letterboxd and Plex usernames can differ - Fetch all pages of the Letterboxd watchlist (was silently capped at ~72 films) - Fix film detail URL to use /film/<slug>/ path (was hitting wrong endpoint) - Match by title AND year to avoid false positives from same-named remakes - Add try/catch in run() so failures exit with a non-zero code and a clear message - Remove dead code: getWatchList, getWatchListMovies, xmlToJSON, unused imports Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
@Slgoetz just in case you missed this long ago, a little bump for you. |
Fix sync reliability: pagination, film URL, year matching, error handling
The script name is how launchd displays the automated task. This means in various macOS displays, the task will be listed as "start.sh", which isn’t very descriptive. By renaming it to "plex-letterboxd-sync", it becomes clear.
Missed in 3d622e0 Signed-off-by: Jeff Byrnes <thejeffbyrnes@gmail.com>
Signed-off-by: Jeff Byrnes <thejeffbyrnes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.