Pull from upstream #7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Changelog | ||
|
|
||
| ## 5.5.3 | ||
|
|
||
| ### Bug Fixes | ||
|
|
||
| - Avoid infinite loop with duplicate header counting (#1095) | ||
|
|
||
| ## 5.5.2 | ||
|
|
||
| ### Bug Fixes | ||
|
|
||
| - Only attempt to parse headers once, fixing performance issue (#1086) | ||
|
|
||
| ### Maintenance | ||
|
|
||
| - Do not run headless tests on CI (#1087) | ||
| - Fix package URL in package.json | ||
|
|
||
| ## 5.5.1 | ||
|
|
||
| ### Maintenance | ||
|
|
||
| - Revert "Remove ES6 features to allow minifying papaparse file" — updated `grunt-contrib-uglify` instead to support ES6+ | ||
| - Update grunt-contrib-uglify version | ||
| - Run build script in CI | ||
|
|
||
| ## 5.5.0 | ||
|
|
||
| ### Features | ||
|
|
||
| - Add `skipFirstNLines` option to skip first N lines before parsing (#1021, #738) | ||
| - Add `renamedHeaders` to parse result meta, reporting original-to-renamed header mappings (#990) | ||
|
|
||
| ### Bug Fixes | ||
|
|
||
| - Fix `escapeFormulae` option to handle boolean values correctly (#1025) | ||
| - Fix cursor position when encountering duplicated headers (#997) | ||
| - Only skip first N lines in the first chunk and don't incorrectly consume the header line (#1045, #1046) | ||
| - Refactor header renaming logic to correctly handle duplicates (#1058, #1052, #1007) | ||
|
|
||
| ### Performance | ||
|
|
||
| - Faster duplicate header detection using a header map (#991) | ||
| - Use `for` loop instead of `for...in` for header parsing to only iterate over array elements (#987) | ||
|
|
||
| ### Maintenance | ||
|
|
||
| - Update minimum ES version to 6 | ||
| - Documentation and README improvements (#1002, #1034, #1041, #1044, #1060) | ||
|
|
||
| ## 5.4.1 | ||
|
|
||
| ### Bug Fixes | ||
|
|
||
| - Remove jsperf.com links from README.md. (#986) | ||
| - Only test duplicate headers on first row | ||
| - Rename duplicated headers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -175,6 +175,24 @@ <h3>Features</h3> | |||||||||||||||||
| <div class="grid-100 text-center"> | ||||||||||||||||||
| <h3>People <i class="fa fa-heart"></i> Papa</h3> | ||||||||||||||||||
| </div> | ||||||||||||||||||
| <div class="grid-100 text-center"> | ||||||||||||||||||
| <br> | ||||||||||||||||||
| <p> | ||||||||||||||||||
| <a href="https://www.npmjs.com/package/papaparse"> | ||||||||||||||||||
| <img | ||||||||||||||||||
| src="https://img.shields.io/npm/dm/papaparse.svg" | ||||||||||||||||||
| alt="PapaParse" | ||||||||||||||||||
| /> | ||||||||||||||||||
| </a> | ||||||||||||||||||
| | ||||||||||||||||||
| <a href="https://www.npmjs.com/package/react-papaparse"> | ||||||||||||||||||
| <img | ||||||||||||||||||
| src="https://img.shields.io/npm/dt/papaparse.svg?label=total%20downloads" | ||||||||||||||||||
| alt="PapaParse" | ||||||||||||||||||
|
Comment on lines
+188
to
+191
There was a problem hiding this comment. Badge/link mismatch for Line 188 links to 🔧 Proposed fix- src="https://img.shields.io/npm/dt/papaparse.svg?label=total%20downloads"
+ src="https://img.shields.io/npm/dt/react-papaparse.svg?label=total%20downloads"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
| /> | ||||||||||||||||||
| </a> | ||||||||||||||||||
| </p> | ||||||||||||||||||
| </div> | ||||||||||||||||||
|
|
||||||||||||||||||
| <div class="grid-33"> | ||||||||||||||||||
| <p class="lover"> | ||||||||||||||||||
|
|
||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -26,6 +26,18 @@ | |||||||||||||||||||||||||
| **/ | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| var peopleLovePapa = [ | ||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||
| link: "http://doctempleapp.com", | ||||||||||||||||||||||||||
| name: "DocTemple", | ||||||||||||||||||||||||||
| description: "helps you effortlessly populate .docx documents with .csv data using scalable templating solution.", | ||||||||||||||||||||||||||
| quote: "Papa Parse made it extremely easy to load user CSV files in the browser. Implementing it was a breeze and it works perfect!" | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||
| link: "https://www.vertex.io", | ||||||||||||||||||||||||||
| name: "The no-code database of the future.", | ||||||||||||||||||||||||||
| description: "No-code, Postgres-powered admin, internal tools, and backend suite.", | ||||||||||||||||||||||||||
| quote: "Vertex uses Papa to power all CSV related features!" | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
|
Comment on lines
+35
to
+40
There was a problem hiding this comment. The Per the file instructions (lines 11-15), the Consider restructuring this entry: 📝 Suggested fix {
link: "https://www.vertex.io",
- name: "The no-code database of the future.",
- description: "No-code, Postgres-powered admin, internal tools, and backend suite.",
+ name: "Vertex",
+ description: "is the no-code database of the future, providing Postgres-powered admin, internal tools, and backend suite.",
quote: "Vertex uses Papa to power all CSV related features!"
},📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||
| link: "https://www.circlehd.com", | ||||||||||||||||||||||||||
| name: "CircleHD Enterprise Video Platform", | ||||||||||||||||||||||||||
|
|
@@ -55,24 +67,6 @@ var peopleLovePapa = [ | |||||||||||||||||||||||||
| name: "Wikipedia", | ||||||||||||||||||||||||||
| description: "uses Papa Parse in VisualEditor to help article editors effortlessly build data tables from text files." | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||
| link: "https://github.com/Nanofus/novel.js", | ||||||||||||||||||||||||||
| name: "Novel.js", | ||||||||||||||||||||||||||
|
|
@@ -97,12 +91,6 @@ var peopleLovePapa = [ | |||||||||||||||||||||||||
| description: "is a brand-new messaging app made specifically for busy families. Automatically align all family members when sending text messages to parents in the kindergarten or school or when planning your kids birthday parties.", | ||||||||||||||||||||||||||
| quote: "With Papa it was a joy to implement our tool for importing messages and places from external systems." | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||
| link: "https://monei.net", | ||||||||||||||||||||||||||
| name: "MONEI", | ||||||||||||||||||||||||||
|
|
@@ -126,5 +114,17 @@ var peopleLovePapa = [ | |||||||||||||||||||||||||
| name: "Visa SOP Sample", | ||||||||||||||||||||||||||
| description: "Providing free guide to international students.", | ||||||||||||||||||||||||||
| quote: "Use Papa Parse for many of side projects. Super fast and works all the time. Love it!" | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||
| link: "https://retool.com/", | ||||||||||||||||||||||||||
| name: "Retool", | ||||||||||||||||||||||||||
| description: "A remarkably fast way to build internal tools.", | ||||||||||||||||||||||||||
| quote: "Papa makes it easy for our users to customize CSV parsing to match their business logic." | ||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||
|
Comment on lines
+118
to
+123
There was a problem hiding this comment. Description missing verb for fluid sentence construction. Per the file instructions, 📝 Suggested fix {
link: "https://retool.com/",
name: "Retool",
- description: "A remarkably fast way to build internal tools.",
+ description: "is a remarkably fast way to build internal tools.",
quote: "Papa makes it easy for our users to customize CSV parsing to match their business logic."
},📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||
| link: "https://www.hellodata.ai/", | ||||||||||||||||||||||||||
| name: "HelloData", | ||||||||||||||||||||||||||
| description: "Automatic rent surveys with real-time data on over 25M multifamily units nationwide, direct from property websites.", | ||||||||||||||||||||||||||
| quote: "Papa Parse makes bulk data imports a breeze! It's helped us easily onboard our largest customers. It's robust and a true game-changer." | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
Comment on lines
+124
to
129
There was a problem hiding this comment. Description missing verb for fluid sentence construction. Same issue as the Retool entry—currently renders as: "HelloData Automatic rent surveys with real-time data..." Consider adding a verb. 📝 Suggested fix {
link: "https://www.hellodata.ai/",
name: "HelloData",
- description: "Automatic rent surveys with real-time data on over 25M multifamily units nationwide, direct from property websites.",
+ description: "provides automatic rent surveys with real-time data on over 25M multifamily units nationwide, direct from property websites.",
quote: "Papa Parse makes bulk data imports a breeze! It's helped us easily onboard our largest customers. It's robust and a true game-changer."
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
| ]; | ||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
Isconst csv = Papa.unparse(data[, config]);valid JavaScript syntax? If not, what is a copy-paste-safe way to document an optional argument in JS examples?💡 Result:
No.
const csv = Papa.unparse(data[, config]);is not valid JavaScript—the[, config]part is documentation notation meaning “configis optional,” as used in Papa Parse’s docs. [1]Copy‑paste‑safe ways to show an optional argument:
1) Show the valid call forms on separate lines (common in MDN docs): [2]
2) Keep code valid and annotate with a comment:
3) Use JSDoc to mark the parameter optional (in comments, not in code): [3]
Sources: [1] Papa Parse docs, [2] MDN “Syntax sections” guidelines, [3] JSDoc
@paramtag docs.🏁 Script executed:
Repository: Skedulo/csv-parser-for-data-loading
Length of output: 340
Use valid JavaScript syntax in the usage example.
Line 39 uses
data[, config], which is not valid JavaScript—this documentation notation for an optional parameter will fail if copied directly into an IDE or runtime. Replace with executable code:Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents