[sitecore-jss-nextjs] Placeholder applies the modifyComponentProps prop.#1668
Open
Adamduehansen wants to merge 2 commits intoSitecore:devfrom
Open
[sitecore-jss-nextjs] Placeholder applies the modifyComponentProps prop.#1668Adamduehansen wants to merge 2 commits intoSitecore:devfrom
Adamduehansen wants to merge 2 commits intoSitecore:devfrom
Conversation
Collaborator
|
@Adamduehansen Thank you for submitting your contribution! I've added a ticket containing all the details, which has been added to our internal backlog for thorough review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
The Placeholder component in the "nextjs package" does not apply the
modifyComponentPropswhen given. Instead, the component adds its own implementation ofmodifyComponentPropsthat it provides to the Placeholder component from the "react package". The component needs to also apply themodifyComponentPropsproperty as well.Testing Details
I tried to add a unit test but I lack knowledge of how Enzyme works. When I attempt to call
mounton the Placeholder component it fails with the messageCannot read properties of null (reading 'useContext'). All other tests seem to have no problems though.So far I tested this solution by modifying the module files inside the node_modules folder of my particular project.
Types of changes