Open
Conversation
stasmaxymov
reviewed
Feb 16, 2026
| @@ -21,124 +18,67 @@ import { rsc } from '#rsc-env'; | |||
| * @public | |||
| */ | |||
| export const AppPlaceholder = (props: AppPlaceholderProps) => { | |||
Collaborator
There was a problem hiding this comment.
AppPlaceholder was designed to work universally in App router and Pages router, with only new requirement - have componentMap and page provided as required props.
Can we make Placeholder just as wrapper over AppPlaceholder? Smth like:
const Placeholder = (props)=>{
const { componentMap, page } = useSitecore();
const appProps = {
...props,
componentMap
page
}
return <AppPlaceholder {...appProps} />
}
If not, what behavior we expect Placeholder to have that is not present in AppPlaceholder?
stasmaxymov
reviewed
Feb 16, 2026
| }; | ||
| }; | ||
|
|
||
| export const drawPlaceholderComponents = ( |
Collaborator
There was a problem hiding this comment.
This function accepts some props and returns back JSX, why won't you make it as React component?
It also accepts drawPlaceholderChildComponent function as parameter, which is also accepts some props and returns JSX, so it is could also be a component passed as parameter. But I think it is possible to make it as regular childern prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Refactors react package with simplicity and best React practices in mind.
passThroughPropsprop to add flexibility in passing props to child componentsrenderEach(Fix behaviour of renderEach in page editing mode #364) Thanks @liamhuberswithPlaceholderand replace it withwithClientPlaceholder- a clientside/SSR analogue towithAppPlaceholderuseComponentMaphook to be used instead ofwithComponentMapwhen needed.componentslogicTesting Details
Types of changes