Open
Conversation
Remove useSitecore dependency from withDatasourceCheck enhancer Replace useSitecore hook with direct pageState and libraryMode props to decouple the enhancer from Sitecore context. Add PageMode and Page type definitions for compatibility. Update isEditing and isDesignLibrary checks to use props instead of context.
…itecoreProvider context Remove SitecoreProviderReactContext dependency from tests and replace mockContext helper with mockPage helper that creates Page objects directly. Simplify test setup by passing page prop directly to components instead of wrapping in Provider. Remove test for "not within SitecoreProvider" scenario as it's no longer applicable. Export Page and PageMode types from enhancer for test usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Issue: #361 (referenced by branch name bugfix/issues-361)
This PR refactors the withDatasourceCheck and withDatasourceCheck tests in sitecore-content-sdk/react to:
useSitecore();and update it as perprops?.page;Files Changed:
Testing Details
Types of changes