Conversation
- Added environment variable for NEXT_PUBLIC_EDITING_HOST to enable build-time dead-code elimination. - Updated API routes to conditionally handle requests based on the editing host environment. - Modified Layout component to load import map only when in editing mode. - Adjusted Sitecore CLI configuration to disable code generation when editing host is active.
📦 Package Size and Test Coverage Report
|
…ic-and-artifacts-to-editing-host-only
- Introduced `isEditingHost` flag derived from the `SITECORE_EDITING_SECRET` environment variable for consistent handling across components. - Updated `next.config.js` to conditionally remove editing API routes for Rendering Hosts. - Modified `Layout` component to utilize the new `isEditingHost` flag for loading import maps. - Added new API routes for handling requests from Sitecore Editor and Component Builder. - Adjusted Sitecore configuration to propagate the editing host flag to the Next.js layer.
…ic-and-artifacts-to-editing-host-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
sitecore.config.tssetsdisableCodeGenerationbased oneditingSecret(fromSITECORE_EDITING_SECRET).next.config.jsuses client-onlyresolve.alias = falsefor.sitecore/import-mapand anIgnorePluginto block deep imports, enabling dead-code elimination.next.config.jsuses client-onlyresolve.alias = falsefor@sitecore-content-sdk/react/dist/esm/components/DesignLibraryand@sitecore-content-sdk/nextjs/editing, plus anIgnorePluginfor deep imports. The component-props loader remains minimal (only stripsgetComponentServerProps), with the bundle stripping handled by the config.Layout.tsxrendersDesignLibraryand loads.sitecore/import-maponly whenscConfig.isEditingHostis true.next.config.jsremovessrc/pages/api/editingbefore Next.js route discovery whenSITECORE_EDITING_SECRETis not set (Rendering Host), and adds the editing rewrite only when Editing Host./api/editing/feaas/renderis removed for Rendering Host via pre-scan deletion, and its rewrite is added only for Editing Host.Testing Details
Types of changes