refactor: extract authentication orchestration to service layer#118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #115
Summary of Changes
Extracted authentication orchestration logic from HTTP handlers to a dedicated service layer:
src/auth/service.pywithAuthenticationServicecontaining login, refresh, and logout methodssrc/http/routers/auth.py- handlers now delegate to service (lines 41-66)PermissionServiceandAuditServicepatterns (Repository+Service with dependency injection)Service orchestrates
UserManager,JWTStrategy,RefreshTokenManager, andAuditService. Handlers became thin wrappers (3-7 lines each). Business logic moved from presentation layer to service layer.Breaking Changes
N/A
Checklist
🤖 Generated with Claude Code