fix: Duplicated string literals#166
Open
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Open
fix: Duplicated string literals#166mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #166 +/- ##
=========================================
+ Coverage 45.1% 49.9% +4.8%
=========================================
Files 350 305 -45
Lines 59747 53313 -6434
=========================================
- Hits 26961 26628 -333
+ Misses 30960 24797 -6163
- Partials 1826 1888 +62
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Duplicated string literals
Category: code-smell
Severity: low
Issue
Multiple files contain duplicated string literals like "human" and "json" for format parameters, which could lead to inconsistencies if changed in the future.
Fix
Introduced named constants for format parameter values (FormatHuman and FormatJSON) to eliminate duplicated string literals. This improves maintainability by centralizing these values and prevents inconsistencies if the format options need to change in the future.
Generated by nyxCore AutoFix