Skip to content

fix: Missing input validation for token scopes #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrwind-up-bird wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: Missing input validation for token scopes #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a75ae1b
Merge pull request #129 from SimplyLiz/develop
SimplyLiz Feb 1, 2026
5e810a4
fix(autofix): Missing input validation for token scopes
mrwind-up-bird Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/ckb/token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@
tokenCreateCmd.Flags().StringVar(&tokenName, "name", "", "Token name (required)")
tokenCreateCmd.Flags().StringSliceVar(&tokenScopes, "scopes", nil, "Scopes: read, write, admin (required)")
tokenCreateCmd.Flags().StringSliceVar(&tokenRepos, "repos", nil, "Restrict to repos matching patterns")
seen := make(map[auth.Scope]bool)
if seen[scope] {

Check failure on line 109 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Test Coverage 

undefined: scope

Check failure on line 109 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Test Coverage 

undefined: scope

Check failure on line 109 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Lint 

undefined: scope

Check failure on line 109 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Test 

undefined: scope

Check failure on line 109 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Analyze 

undefined: scope

Check failure on line 109 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Security Scan 

undefined: scope

Check failure on line 109 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Go SAST / Gosec Security Scan 

undefined: scope

Check failure on line 109 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

undefined: scope

Check failure on line 109 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

undefined: scope
continue // Skip duplicate scopes

Check failure on line 110 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Test Coverage 

continue is not in a loop

Check failure on line 110 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Test Coverage 

continue is not in a loop

Check failure on line 110 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Lint 

continue is not in a loop

Check failure on line 110 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Test 

continue is not in a loop

Check failure on line 110 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Analyze 

continue is not in a loop

Check failure on line 110 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Security Scan 

continue not in for statement

Check failure on line 110 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Go SAST / Gosec Security Scan 

continue is not in a loop

Check failure on line 110 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

continue not in for statement

Check failure on line 110 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

continue not in for statement
}
seen[scope] = true

Check failure on line 112 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Test Coverage 

undefined: scope

Check failure on line 112 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Test Coverage 

undefined: scope

Check failure on line 112 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Lint 

undefined: scope (typecheck)

Check failure on line 112 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Test 

undefined: scope

Check failure on line 112 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Analyze 

undefined: scope

Check failure on line 112 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Security Scan 

undefined: scope

Check failure on line 112 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Go SAST / Gosec Security Scan 

undefined: scope

Check failure on line 112 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

undefined: scope

Check failure on line 112 in cmd/ckb/token.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

undefined: scope
tokenCreateCmd.Flags().StringVar(&tokenExpires, "expires", "", "Expiration (e.g., 30d, 1h, 2024-12-31)")
tokenCreateCmd.Flags().IntVar(&tokenRateLimit, "rate-limit", 0, "Rate limit (requests per minute, 0=default)")
_ = tokenCreateCmd.MarkFlagRequired("name")
Expand Down
Loading