fix: Duplicate path expansion logic#163
Open
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Open
fix: Duplicate path expansion logic#163mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Duplicate path expansion logic
Category: code-smell
Severity: low
Issue
The expandPath function duplicates standard library functionality for tilde expansion that could be handled by os.UserHomeDir() directly, adding unnecessary complexity.
Fix
Simplified the expandPath function by removing the duplicate error handling and prefix check. The filepath.Join function handles the case where home is empty (returns the original path), and strings.TrimPrefix safely handles paths that don't start with "~/" by returning them unchanged. This eliminates the unnecessary complexity while maintaining the same functionality.
Generated by nyxCore AutoFix