fix: Missing input validation in GitLab CI#149
Open
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Open
fix: Missing input validation in GitLab CI#149mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #149 +/- ##
=========================================
+ Coverage 45.1% 45.6% +0.5%
=========================================
Files 350 367 +17
Lines 59747 61934 +2187
=========================================
+ Hits 26961 28285 +1324
- Misses 30960 31736 +776
- Partials 1826 1913 +87
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Missing input validation in GitLab CI
Category: security
Severity: medium
Issue
GitLab CI configuration uses shell commands with variables like CI_MERGE_REQUEST_DIFF_BASE_SHA without validation. These could potentially contain malicious input leading to command injection.
Fix
The fix sanitizes GitLab CI variables (CI_MERGE_REQUEST_DIFF_BASE_SHA and CI_COMMIT_SHA) by filtering out any non-hexadecimal characters using printf and tr commands. This prevents command injection attacks by ensuring only valid Git SHA hashes (containing only a-f and 0-9 characters) are used in shell commands. The fix is applied consistently across all instances where these variables are used in git diff and ckb impact commands.
Generated by nyxCore AutoFix