fix: Magic numbers in configuration#146
Open
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Open
fix: Magic numbers in configuration#146mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #146 +/- ##
=========================================
+ Coverage 45.1% 45.6% +0.5%
=========================================
Files 350 367 +17
Lines 59747 61934 +2187
=========================================
+ Hits 26961 28274 +1313
- Misses 30960 31744 +784
- Partials 1826 1916 +90
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Magic numbers in configuration
Category: code-smell
Severity: low
Issue
Multiple workflow files contain hardcoded magic numbers like '24h', '30 days', and '90 days' without clear documentation or configuration variables.
Fix
Replaced magic numbers with named configuration constants at the top of the workflow file. Added DEFAULT_TELEMETRY_DAYS (30), DEFAULT_RETENTION_DAYS (90), and DEFAULT_STALE_THRESHOLD (24h) as environment variables, then referenced these constants throughout the workflow instead of hardcoded values. This improves maintainability and makes the configuration intent clearer.
Generated by nyxCore AutoFix