fix: Unbounded file upload without validation#145
Open
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Open
fix: Unbounded file upload without validation#145mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Unbounded file upload without validation
Category: security
Severity: high
Issue
Delta ingestion endpoints accept up to 50MB of data without content-type validation or signature verification. This could allow malicious delta artifacts to be uploaded, potentially leading to SCIP index poisoning attacks.
Fix
Added content-type validation to both delta ingestion endpoints to ensure only JSON payloads are accepted. This prevents malicious uploads of non-JSON content that could potentially exploit parsing vulnerabilities. The validation checks for exact 'application/json' type or any JSON subtype (like 'application/json; charset=utf-8').
Generated by nyxCore AutoFix