Skip to content

fix: Silent error swallowing in JSON encoding #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrwind-up-bird wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: Silent error swallowing in JSON encoding #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a75ae1b
Merge pull request #129 from SimplyLiz/develop
SimplyLiz Feb 1, 2026
bf2b891
fix(autofix): Silent error swallowing in JSON encoding
mrwind-up-bird Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/api/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@
resp.Code = "INTERNAL_ERROR"
}

_ = json.NewEncoder(w).Encode(resp)
if err := json.NewEncoder(w).Encode(resp); err != nil {
// Log encoding error, but don't fail the response since headers are already sent
}
}

// WriteCkbError writes a CkbError with automatic status code mapping
Expand All @@ -51,7 +53,9 @@
return http.StatusServiceUnavailable // 503
case errors.IndexMissing:
return http.StatusNotFound // 404
case errors.IndexStale:
if err := json.NewEncoder(w).Encode(data); err != nil {

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Security Scan 

undefined: data

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Security Scan 

undefined: w

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Test 

undefined: data

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Test 

undefined: w

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Test Coverage 

undefined: data

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Test Coverage 

undefined: w

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Analyze 

undefined: data

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Analyze 

undefined: w

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Lint 

undefined: data (typecheck)

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Lint 

undefined: w

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

undefined: data

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

undefined: w

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

undefined: data

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Dependencies / Dependency Scan 

undefined: w

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Go SAST / Gosec Security Scan 

undefined: data

Check failure on line 56 in internal/api/errors.go

View workflow job for this annotation

GitHub Actions / Go SAST / Gosec Security Scan 

undefined: w
// Log encoding error, but don't fail the response since headers are already sent
}
return http.StatusPreconditionFailed // 412
case errors.WorkspaceNotReady:
return http.StatusServiceUnavailable // 503
Expand Down
Loading