Some renamings to reduce unnecessary variable naming diversity#216
Open
mallamanis wants to merge 3 commits intoSimonVT:masterfrom
mallamanis:suggestions
Open
Some renamings to reduce unnecessary variable naming diversity#216mallamanis wants to merge 3 commits intoSimonVT:masterfrom mallamanis:suggestions
mallamanis wants to merge 3 commits intoSimonVT:masterfrom
mallamanis:suggestions
Conversation
MenuDrawer.java naming convention.
in 9 positions in the sample, while mDrawer was used 5 times. This commit makes the naming more consistent throught the samples.
was previously used 14 times in the code, while savedInstanceState only 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on a research machine learning-based tool (link: http://groups.inf.ed.ac.uk/naturalize/ ) tool that analyzes source code identifiers and makes suggestions for renaming them. The goal is to reduce unnecessary diversity in variable naming and improve code readability. This pull request is only a small sample of the suggestions made for android-menudrawer.
No functional changes were made in any of the commits