Exclude branches collapsed by zero-impedance breaker merges#303
Open
acostarelli wants to merge 1 commit into
Open
Exclude branches collapsed by zero-impedance breaker merges#303acostarelli wants to merge 1 commit into
acostarelli wants to merge 1 commit into
Conversation
The implicit breaker-merge in Ybus construction can map both endpoints of a parallel non-breaker branch to the same surviving bus, producing a self-loop arc. This corrupted the incidence matrix and crashed _build_row_to_cols inside RadialReduction. Bundle the existing breaker merge and a new collapsed-branch sweep into _apply_implicit_reductions!. Flag collapsed branches via a skip set that _get_ybus_two_terminal_ac_branches consults, so they never enter the matrix. Also harden _build_row_to_cols to error on incomplete rows instead of returning uninitialized memory. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Performance ResultsPrecompile Time
Execution Time
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.