[Do not review yet] IOM-side port of PSI#1579 (SCUC branch formulation using MODF)#102
Draft
acostarelli wants to merge 2 commits into
Draft
[Do not review yet] IOM-side port of PSI#1579 (SCUC branch formulation using MODF)#102acostarelli wants to merge 2 commits into
acostarelli wants to merge 2 commits into
Conversation
Bumps PNM compat to ^0.20 for VirtualMODF. Renames the NetworkModel LODF_matrix field to MODF_matrix (PNM.VirtualMODF). Adds an outages field/kwarg/getter on DeviceModel plus a _formulation_supports_outages trait that POM will specialize for AbstractSecurityConstrainedStaticBranch. Adds sparse-axis paths for post-contingency duals across dual_processing, optimization_container, decision_model_store, and add_constraint_dual. Extends Base.isempty/empty! on BranchReductionOptimizationTracker to cover constraint_map_by_type. PSI's power-specific changes (devices_models, network_models, services_models, contingency_model, template_validation, etc.) remain out of scope here and will follow in POM. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
Performance Results This branch |
Adds four MODF helpers that PSI placed in core/network_model.jl but are PSY-free, so they belong in IOM rather than POM: - _build_network_reductions: pure PNM, drop-in. - _validate_provided_modf_reduction!: pure PNM, drop-in. - _template_has_outage_aware_branch: recast from PSI's _template_uses_security_constrained_branch to dispatch on the _formulation_supports_outages trait (already in IOM) rather than the POM-resident AbstractSecurityConstrainedStaticBranch type. - _consolidate_device_model_outages_with_modf!: same recast; name kept. The POM port will call these via IOM.* directly. The remaining new helpers in PSI's network_model.jl (irreducible-bus discovery for monitored components, instantiate_network_model! updates) stay POM-bound because they need PSY.System / PSY.Branch / PSY.has_time_series / etc. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps PNM compat to ^0.20 for VirtualMODF. Renames the NetworkModel LODF_matrix field to MODF_matrix (PNM.VirtualMODF). Adds an outages field/kwarg/getter on DeviceModel plus a _formulation_supports_outages trait that POM will specialize for AbstractSecurityConstrainedStaticBranch. Adds sparse-axis paths for post-contingency duals across dual_processing, optimization_container, decision_model_store, and add_constraint_dual. Extends Base.isempty/empty! on BranchReductionOptimizationTracker to cover constraint_map_by_type.