Skip to content

[201] Add batch_charge fee support#381

Merged
orunganiekan merged 1 commit into
SiLioLabs:masterfrom
Goodnessukaigwe:feat/batch-charge-fee
Jun 4, 2026
Merged

[201] Add batch_charge fee support#381
orunganiekan merged 1 commit into
SiLioLabs:masterfrom
Goodnessukaigwe:feat/batch-charge-fee

Conversation

@Goodnessukaigwe
Copy link
Copy Markdown
Contributor

Summary

  • Extracted shared fee-aware charge execution in charge_exec used by both charge() and batch_charge().
  • Protocol fees are split to the collector and net amount to the merchant identically in single and batch paths.
  • Added test_batch_charge_with_fee regression test; fixed baseline compile/test issues on the contract crate.

Test plan

  • cargo fmt
  • cargo clippy
  • cargo test (85 tests passing)

Closes #201

Made with Cursor

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 2, 2026

@Goodnessukaigwe Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Extract charge execution into charge_exec so batch_charge and charge()
apply identical protocol fee splits, revenue accounting, history, and events.
Fix compile issues (duplicate getter, bench gating, test file structure).

Closes SiLioLabs#201

Co-authored-by: Cursor <cursoragent@cursor.com>
@Goodnessukaigwe Goodnessukaigwe force-pushed the feat/batch-charge-fee branch from 9d36875 to 93f987f Compare June 4, 2026 17:44
@orunganiekan orunganiekan merged commit 9bf9493 into SiLioLabs:master Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add batch_charge fee support

2 participants