Search in context or a set of contexts.#9
Draft
danilyanich wants to merge 2 commits intoShunkevichDV:scp_stable_contextfrom
Draft
Search in context or a set of contexts.#9danilyanich wants to merge 2 commits intoShunkevichDV:scp_stable_contextfrom
danilyanich wants to merge 2 commits intoShunkevichDV:scp_stable_contextfrom
Conversation
Collaborator
|
@danilyanich How can I test your functionality? |
Collaborator
Resolved. Please, test this functionality on concerted_part_of_kb, support of which was added recently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a kind of work in progress. We were not able to test it out properly.
Also this code must be lifted up and used by all search agents that relied on
NOT_IN_CONTEXTmacro.Also we have no idea how performant this code is. Previous realization used a macro, and now there will be 4 function calls at worst and an iterator allocation.
cc @arlovaalina