feat: add support for flow config fields in liquid lsp#1141
Draft
Gasser-Aly wants to merge 1 commit intomainfrom
Draft
feat: add support for flow config fields in liquid lsp#1141Gasser-Aly wants to merge 1 commit intomainfrom
Gasser-Aly wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What are you adding in this PR?
This PR adds support for URI-scoped object definitions in the theme language server. The implementation allows objects to be registered and retrieved on a per-URI basis, enabling more granular control over which objects are available in different contexts.
The key changes include:
getObjectsForURImethod to theThemeDocsetinterface as an optional methodAugmentedThemeDocsetwith both exact and prefix matching capabilitiesUndefinedObjectcheck to use URI-specific objects when availableTypeSystemto consider URI context when building object maps and symbol tablesSetObjectsNotificationto allow clients to register objects for specific URIsThis enables different files or paths to have different sets of available objects, which is useful for context-specific Liquid environments.
What's next? Any followup issues?
The implementation provides the foundation for URI-scoped objects. Follow-up work might include:
What did you learn?
The prefix matching implementation allows for flexible URI-based scoping where you can register objects for a base path and have them apply to all files within that path hierarchy. This provides a good balance between specificity and maintainability.