Drop support for Ruby 2.7, 3.0, and 3.1 for CI#74
Merged
Edouard-chin merged 4 commits intoShopify:mainfrom Dec 12, 2025
Merged
Conversation
and Bundler generates a warning for this.
Tests were failing due to Bundler's warning messages, "already initialized constant": ruby/rubygems@a2b51a6 and ruby/rubygems@41529af. These warnings were fixed at Bundler 2.7.0. But it also dropped support for Ruby <= 3.1. So this patch dropped support for older Rubies, and upgrade Bundler to the latest 2.x version. Bundler 4.x has been already released, but it has other issues. So this patch upgrades Bundler to the latest 2.x version. The required_ruby_version attribute in the gemspec file is intentionally not changed since this is an issue only around testing.
Ruby 3.3 shows a warning if mutex_m is implicitly used. minitest v5.21.0 has a fix for this: minitest/minitest#973
This reverts commit 8513db1. It seems that the Bundler version is set to the latest for older Bundler: Shopify#66 (comment) This is not the case now, and Bundler version is written in Gemfile.lock. Currently, this configuration makes the CI use Bundler v4, which somehow produces an error.
Contributor
Author
|
I have signed the CLA! |
Member
|
Thank you 🙇 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, CI tests are broken: https://github.com/Shopify/bootboot/actions/runs/18923984894/job/54026845459
I tried to solve this and found that we need to drop support for obsolete Rubies to achieve a clean solution. This pull request did:
The above warnings cause some test cases to fail because they generate warning messages.
This is technically a breaking change, though I believe that no big issues will occur when using bootboot with older Rubies.