Skip to content

Remove Autoredirect by Default in Remote Viewer #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
brianleshopify wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove Autoredirect by Default in Remote Viewer #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/app_profiler/viewer/speedscope_remote_viewer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,12 @@ def view(response: nil, autoredirect: nil, async: false)
id = Middleware.id(@profile.file)

if response && response[0].to_i < 500
response[1]["Location"] = "/app_profiler/#{id}"
response[0] = 303
if autoredirect
response[0] = 303
response[1]["Location"] = "/app_profiler/#{id}"
elsif AppProfiler.profile_header
response[1][AppProfiler.profile_header] = "/app_profiler/#{id}"
end
else
AppProfiler.logger.info("[Profiler] Profile available at /app_profiler/#{id}\n")
end
Expand Down
17 changes: 15 additions & 2 deletions test/app_profiler/viewer/speedscope_remote_viewer_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,27 @@ class SpeedscopeRemoteViewerTest < TestCase
viewer.view
end

test "#view with response redirects to URL" do
test "#view with response sets the profiler header" do
response = [200, {}, ["OK"]]
profile = BaseProfile.from_stackprof(stackprof_profile)

view = SpeedscopeRemoteViewer.new(profile)
id = SpeedscopeRemoteViewer::Middleware.id(profile.file)

view.view(response: response)

assert_equal(200, response[0])
assert_equal("/app_profiler/#{id}", response[1][AppProfiler.profile_header])
end

test "#view with response redirects to URL when autoredirect is set" do
response = [200, {}, ["OK"]]
profile = BaseProfile.from_stackprof(stackprof_profile)

viewer = SpeedscopeRemoteViewer.new(profile)
id = SpeedscopeRemoteViewer::Middleware.id(profile.file)

viewer.view(response: response)
viewer.view(response: response, autoredirect: true)

assert_equal(303, response[0])
assert_equal("/app_profiler/#{id}", response[1]["Location"])
Expand Down