feat: Sub-workflow (core.workflow.call) with parent/child navigation #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and a single `result` object output. - New component `core.workflow.call` with dynamic input ports derived from selected child entrypoint `runtimeInputs`: `worker/src/components/core/workflow-call.ts:34` - Temporal orchestration special-cases `core.workflow.call` to `prepareRunPayloadActivity` + `startChild(shipsecWorkflowRun)` + await result/timeout: `worker/src/temporal/workflows/index.ts:183` - Parent/child linkage persisted on the child run (`parent_run_id`, `parent_node_ref`) via new migration `backend/drizzle/0018_add-subworkflow-linkage.sql:7` - Internal run prep accepts linkage fields (`parentRunId`, `parentNodeRef`): `backend/src/workflows/dto/workflow-graph.dto.ts:109` - New API endpoint to list children: `GET /api/v1/workflows/runs/:runId/children` at `backend/src/workflows/workflows.controller.ts:410` (service impl: `backend/src/workflows/workflows.service.ts:522`) - Frontend workflow selector for `core.workflow.call.workflowId` that auto-syncs `childRuntimeInputs` and triggers port re-resolution: `frontend/src/components/workflow/ParameterField.tsx:94` - Trace metadata extended with optional `childRunId/parentRunId/parentNodeRef/depth`: `packages/shared/src/execution.ts:121` - Per your request, `openapi.json` patched directly and client regenerated: `openapi.json:505`, `openapi.json:5326`, `packages/backend-client/src/client.ts` To apply DB changes: run `bun run --cwd backend migration:push` (or your normal Drizzle migration flow). Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
- Create child workflow that computes 21 * multiplier - Create parent workflow that calls child and consumes its output - Verify child output (result=42) flows correctly to parent - Verify trace events contain childRunId linkage - Uses proper edge-based input mappings (sourceHandle/targetHandle) Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
- Add parentRunId and parentNodeRef fields to run API response - Add floating breadcrumb on canvas when viewing child runs - Add 'View Child Run' button on workflow.call nodes - Add /runs/:runId redirect route for navigation - Add RunBreadcrumbs component with floating/inline variants - Add getChildRuns API method for listing child runs - Update runStore to include parent run fields Navigation flow: - Parent run: 'View Child Run' button appears on call-child node - Child run: Floating breadcrumb links back to parent workflow Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+358
to
+361
| const timeoutMs = timeoutSeconds * 1000 | ||
| const outcome = await Promise.race([ | ||
| child.result().then((result) => ({ kind: 'result' as const, result })), | ||
| sleep(timeoutMs).then(() => ({ kind: 'timeout' as const })), |
There was a problem hiding this comment.
child.result() rejects when the child workflow throws (and shipsecWorkflowRun always throws on failure rather than returning { success: false }). In that case the Promise.race rejects before outcome is set, so the NODE_FAILED trace with childRunId is never recorded and this node is left with a last event of NODE_STARTED (UI shows it stuck “running” even though the parent run failed). Wrap child.result() in a .catch/try path that records a failure event and rethrows.
Useful? React with 👍 / 👎.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the sub-workflow feature (
core.workflow.call), enabling workflows to call other workflows as child processes and consume their outputs. It includes full parent/child navigation UI for seamless workflow debugging.Features
1. Sub-workflow Component (
core.workflow.call)resultobject containing all node outputslatestor pinned version selection2. Parent/Child Navigation
View Child Run button: Appears on
core.workflow.callnodes after execution completesFloating breadcrumb: Shows on canvas when viewing a child run
Run redirect route:
/runs/:runIdautomatically redirects to/workflows/:workflowId/runs/:runId3. API Enhancements
parentRunIdandparentNodeReffields added to run responsesGET /api/v1/workflows/runs/:runId/childrenendpoint for listing child runschildRunIdin metadata for workflow.call nodesTesting
Run tests:
RUN_E2E=true bun test e2e-tests/subworkflow.test.tsFiles Changed
Backend
backend/src/workflows/workflows.service.ts- Added parentRunId/parentNodeRef to run summaryWorker
worker/src/components/core/workflow-call.ts- Core workflow.call component implementationFrontend
frontend/src/components/workflow/WorkflowNode.tsx- View Child Run button on nodesfrontend/src/components/workflow/WorkflowBuilderShell.tsx- Execution overlay supportfrontend/src/components/timeline/RunBreadcrumbs.tsx- New breadcrumb componentfrontend/src/pages/RunRedirect.tsx- New redirect pagefrontend/src/features/workflow-builder/WorkflowBuilder.tsx- Breadcrumb integrationfrontend/src/store/runStore.ts- Parent run fields in storefrontend/src/services/api.ts- getChildRuns API methodPackages
packages/backend-client/src/api-client.ts- listWorkflowRunChildren method