Changed config path for SH fields to avoid conflict with General tab#2
Open
rain2o wants to merge 1 commit into
Open
Changed config path for SH fields to avoid conflict with General tab#2rain2o wants to merge 1 commit into
rain2o wants to merge 1 commit into
Conversation
lfluvisotto
added a commit
to lfluvisotto/shiphawk-magento-2
that referenced
this pull request
Apr 3, 2024
…subject) of type string is deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a solution for issue #1 . I have modified the config path for the ShipHawk Order section to be
shiphawk_orderand updated all references to these fields.Doing so allows the General -> General section and fields to go back to their original place to avoid confusion for Magento users who install this module.