Booking Appointments in other locations#658
Open
luxigo wants to merge 4 commits intoSergeyMosin:masterfrom
Open
Booking Appointments in other locations#658luxigo wants to merge 4 commits intoSergeyMosin:masterfrom
luxigo wants to merge 4 commits intoSergeyMosin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Sergey,
You've handled the complexity nicely for this app.
It was not as easy as it seemed to dig into it: with no debugger handy, logger->error(json_encode()) was my only friend in the nextcloud_aio_nextcloud container... :-)
For appointments in other locations, add a textarea in the extra fields with the "data-is_location" attribute set:
I guess there is some work left for other use cases, but it seems it kinda fix #606 for me right now.
Regards,
Luc Deschenaux