fix: break circular dependency via dispatch registry#20
Merged
Conversation
Introduce a dispatch registry (`queryDispatch.ts`) as a leaf module that both Shape and LinkedStorage import without importing each other. Remove QueryParser (was a pass-through with no logic). LinkedStorage registers as the dispatch provider in `setDefaultStore()`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
If this change doesn't need a release (docs, CI config, etc.), you can ignore this message. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
flyon
force-pushed
the
flyon/fix-circular-deps
branch
from
5ffbde4 to
33e9fb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shape → QueryParser → LinkedStorage → Shapeby introducing a leaf dispatch module (queryDispatch.ts)getQueryDispatch()to execute queries; LinkedStorage registers itself as the dispatch provider insetDefaultStore()QueryParserentirely (was a 79-line pass-through with no logic)Shape— usesFunctionprototype-chain walking for store resolutionTest plan
tsc --noEmitpasses🤖 Generated with Claude Code