[Bugfix] Fix inadvertently persistent test artifacts #853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test_flows_seed.pyhad two instances whereSettings.HOSTNAMEwas being overridden in a way that affected the remainder of the test suite. Neither case was even necessary for the test and so was removed.test_flows_view.pyanother unnecessarySettings.HOSTNAMEoverride.test_settings_definition.py:os.walkwas unintentionally being permanently mocked out for the remainder of thepytestrun, creating confusing side effects in an unrelated test. Changed to apatch.This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before submitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: