Skip to content

Conversation

@kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Dec 18, 2025

Description

  • test_flows_seed.py had two instances where Settings.HOSTNAME was being overridden in a way that affected the remainder of the test suite. Neither case was even necessary for the test and so was removed.

  • test_flows_view.py another unnecessarySettings.HOSTNAME override.

  • test_settings_definition.py: os.walk was unintentionally being permanently mocked out for the remainder of the pytest run, creating confusing side effects in an unrelated test. Changed to a patch.


This pull request is categorized as a:

  • Bug fix

Checklist

  • I’ve run pytest and made sure all unit tests pass before submitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • N/A

I have tested this PR on the following platforms/os:

  • Other: Only applies when running the test suite in local dev or CI

@alvroble
Copy link
Contributor

ACK tested

@kdmukai kdmukai changed the title [Bugfix] Test case-specific Mock should not persist outside of its test case [Bugfix] Fix inadvertently persistent test artifacts Dec 20, 2025
@securesigner
Copy link

Ran pytest on modified files and executed full test suite run_full_coverage.sh. All 140 tests passed

alvroble added a commit to alvroble/seedsigner that referenced this pull request Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants