Add unit tests for repypp.py#163
Open
XuefengHuang wants to merge 26 commits intoSeattleTestbed:masterfrom
XuefengHuang:repypp.py-unittests
Open
Add unit tests for repypp.py#163XuefengHuang wants to merge 26 commits intoSeattleTestbed:masterfrom XuefengHuang:repypp.py-unittests
XuefengHuang wants to merge 26 commits intoSeattleTestbed:masterfrom
XuefengHuang:repypp.py-unittests
Conversation
This script tests if repypp.py check erroneous #include statements(have multiple arguments).
This script tests if repypp.py check erroneous #include statements(include non-existing files
Contributor
There was a problem hiding this comment.
That's a very terse description. We should mention the Repy preprocessor (as some other tests do), and what the expected correct outcome is.
Contributor
|
For reference, this is in response to #161. |
Contributor
There was a problem hiding this comment.
Small typo: We want to refer to a non-existing file rather than a non-exiting (note "s").
Since the name using tempfile module which is not satisfied the requirement of Repy, so I discard it. And I give more explanations, modify file names. Also checking whether the file contents match what we expect.
Since the name using tempfile module which is not satisfied with the requirement of Repy, so I discard it. And I give more explanations, modify file names.
Since the name using tempfile module which is not satisfied the requirement of Repy, so I discard it. And I give more explanations, modify file names.
This script tests if repypp.py check erroneous #include statements(have multiple arguments).
This script tests if repypp.py check erroneous #include statements(have no arguments at all).
This script tests if some comments(include some_lib.repy # Ensure that comments are ignored, even if preceded by whitespace) are ignored.
Contributor
There was a problem hiding this comment.
Please limit line lengths to approximately 70 characters. (This eases editing on text-based terminals.)
Contributor
There was a problem hiding this comment.
I suggest we split this test so that we can output two more specific error messages, e.g. "repypp failed to include the specified file .....", and "repypp incorrectly touched file contents" (or similar).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tests
repypp.py:1.Correct #include statements
2.Erroneous #include statements:
include non-existing files,
have multiple arguments,
have no arguments at all.