-
Notifications
You must be signed in to change notification settings - Fork 2
[CHORE] 로컬 / 개발 환경 분리 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,5 +42,3 @@ secrets.yml | |
| .sts4-cache | ||
|
|
||
| .idea | ||
|
|
||
| src/main/resources/application.yml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| spring: | ||
| application: | ||
| name: SeCause-be | ||
| datasource: | ||
| driver-class-name: org.postgresql.Driver | ||
| url: ${DB_URL} | ||
| username: ${DB_USERNAME} | ||
| password: ${DB_PASSWORD} | ||
| sql: | ||
| init: | ||
| mode: always | ||
| separator: "@@" | ||
| jpa: | ||
| hibernate: | ||
| ddl-auto: validate | ||
|
|
||
| springdoc: | ||
| swagger-ui: | ||
| path: /swagger-ui.html | ||
| operations-sorter: method | ||
| prod-server: ${SWAGGER_SERVER_URL} | ||
| api-docs: | ||
| path: /api-docs | ||
|
|
||
| github: | ||
| oauth: | ||
| client-id: ${GITHUB_CLIENT_ID} | ||
| client-secret: ${GITHUB_CLIENT_SECRET} | ||
| redirect-uri: ${GITHUB_REDIRECT_URI} | ||
|
|
||
| jwt: | ||
| secret: ${JWT_SECRET} | ||
| access-token-expiration: ${JWT_ACCESS_TOKEN_EXPIRATION:3600000} | ||
| refresh-token-expiration: 1209600000 # 14일 | ||
| refresh-secret: ${REFRESH_SECRET} | ||
| refresh-token-hash-secret: ${REFRESH_TOKEN_HASH_SECRET} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| spring: | ||
| application: | ||
| name: SeCause-be | ||
| datasource: | ||
| driver-class-name: org.postgresql.Driver | ||
| url: ${LOCAL_DB_URL:jdbc:postgresql://localhost:5433/secausedb} | ||
| username: ${LOCAL_DB_USERNAME:postgres} | ||
| password: ${LOCAL_DB_PASSWORD:} | ||
| sql: | ||
| init: | ||
| mode: always | ||
| separator: "@@" | ||
| jpa: | ||
| hibernate: | ||
| ddl-auto: update | ||
|
|
||
| springdoc: | ||
| swagger-ui: | ||
| path: /swagger-ui.html | ||
| operations-sorter: method | ||
| prod-server: ${SWAGGER_SERVER_URL:http://localhost:8080} | ||
| api-docs: | ||
| path: /api-docs | ||
|
|
||
|
|
||
| github: | ||
| oauth: | ||
| client-id: ${GITHUB_CLIENT_ID:} | ||
| client-secret: ${GITHUB_CLIENT_SECRET:} | ||
| redirect-uri: ${GITHUB_REDIRECT_URI:http://localhost:3000/login/callback} | ||
|
|
||
| jwt: | ||
| secret: ${JWT_SECRET:secause-local-jwt-secret-key-2026-development-only} | ||
| access-token-expiration: ${JWT_ACCESS_TOKEN_EXPIRATION:3600000} | ||
|
dldusgh318 marked this conversation as resolved.
|
||
| refresh-token-expiration: 1209600000 # 14일 | ||
| refresh-secret: ${JWT_REFRESH_SECRET_LOCAL:secause-secret-key-for-local-development-2026} | ||
| refresh-token-hash-secret: ${JWT_REFRESH_HASH_SECRET_LOCAL:secause-hash-secret-key-for-local-development-2026} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| spring: | ||
| profiles: | ||
| active: local |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
배포 이미지를
latest대신 불변 태그로 고정하세요.현재 배포가
${DOCKER_REPO}:latest를 pull/up 하므로, 워크플로우가 연속 실행될 때 의도한 커밋이 아닌 이미지가 올라갈 수 있습니다. 빌드에서 이미${{ github.sha }}를 push하고 있으니 배포도 동일 SHA 태그를 사용해 원자적으로 맞추는 편이 안전합니다.제안 변경안
- name: Deploy to server with Docker uses: appleboy/ssh-action@master env: DOCKER_REPO: ${{ secrets.DOCKER_REPO }} + IMAGE_TAG: ${{ github.sha }} with: @@ - envs: DOCKER_REPO + envs: DOCKER_REPO,IMAGE_TAG script: | @@ cat > docker-compose.yml <<EOF services: secause: - image: ${DOCKER_REPO}:latest + image: ${DOCKER_REPO}:${IMAGE_TAG} container_name: secauseAlso applies to: 85-86
🤖 Prompt for AI Agents