vc-render-tifxyz: add opt-in normal direction flip#1055
Open
LubuSeb wants to merge 1 commit into
Open
Conversation
|
@LubuSeb is attempting to deploy a commit to the scroll Team on Vercel. A member of the Team first needs to authorize it. |
1caa5fd to
090cf37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1044.
Summary
--flip-normalsflag tovc_render_tifxyzScope / Minimality
This patch is limited to
volume-cartographer/apps/src/vc_render_tifxyz.cpp.It does not change the default normal orientation policy, surface generation, affine transform behavior, output post-processing, or tile scheduling. The option is deliberately off by default because issue #1044 discussed making the reversed normal direction available as an optional flag rather than changing defaults globally.
Reproduction / Context
Issue #1044 reports that readable UV-space text can render with the opposite orientation from what the reporter expects, and asks whether
vc_render_tifxyzshould flip normal direction. The maintainer discussion explicitly allows adding the behavior as an optional flag rather than changing default behavior.The relevant renderer path generates surface points and normals, normalizes the direction vectors, then samples image data at slice offsets along those normals. Without an opt-in switch, users have to change segment orientation or modify code locally to sample in the opposite direction. This patch exposes that opposite sampling direction as a CLI option while preserving the existing default.
Issue / Artifact Binding
LubuSeb:codex/villa-1044-flip-normalsValidation
Run in the project Docker builder:
cmake --preset ci-tests-gcc cmake --build --preset ci-tests-gcc --target vc_render_tifxyz ./build/ci-tests-gcc/bin/vc_render_tifxyz --help | grep -q -- --flip-normals cmake --build --preset ci-tests-gcc ctest --preset ci-tests-gcc --output-on-failureResults:
vc_render_tifxyzbuilt successfully.--flip-normalsis exposed byvc_render_tifxyz --help.97/97tests.git diff --checkpassed; only Windows LF-to-CRLF warnings were emitted by Git.Known Limits
I validated the control path, build, CLI exposure, and full Dockerized test suite. I did not have a reviewer-provided segment/volume pair with a known desired flipped-normal rendering, so this PR implements the requested opt-in direction switch without asserting that it should become the default.