VC3D: add non-destructive surface view orientation controls#1051
Open
LubuSeb wants to merge 1 commit into
Open
VC3D: add non-destructive surface view orientation controls#1051LubuSeb wants to merge 1 commit into
LubuSeb wants to merge 1 commit into
Conversation
|
@LubuSeb is attempting to deploy a commit to the scroll Team on Vercel. A member of the Team first needs to authorize it. |
ade98b7 to
7b71a3a
Compare
7b71a3a to
848a68d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #370.
Issue: #370
Reproduction
VC3D currently has saved-surface rotate/flip actions, but the active surface-view image itself cannot be rotated or flipped non-destructively for inspection. Issue #370 asks for rotate and horizontal flip controls so users can inspect a surface or ink prediction from a different orientation without mutating saved surface geometry.
Changes
Ctrl+Rfor rotate because plainris already bound to "Center focus on cursor"; used plainffor horizontal flip to match the issue suggestion where no existing plain-key conflict was found.Scope / Minimality
This is focused on the active view only. It does not call or change the existing saved-surface rotate/flip commands, does not modify persisted surface geometry, and does not change unrelated VC3D controls or non-VC3D subprojects.
Validation
git diff --check.cmake --preset ci-release-gcc && cmake --build --preset ci-release-gccusingghcr.io/scrollprize/villa/volume-cartographer:builder-ubuntu-26.04; it passed.cmake --preset ci-tests-gcc && cmake --build --preset ci-tests-gcc && ctest --preset ci-tests-gcc; it passed with 97/97 CTest tests.cmake --build --preset ci-tests-gcc && ctest --preset ci-tests-gcc --output-on-failurethrough the same builder image; it passed.timeout 8s xvfb-run -a build/ci-tests-gcc/bin/VC3D; VC3D started, logged normal viewer initialization, and stayed alive until the timeout.Known Limits / Non-goals