New cronjobMgr service#53
Merged
Merged
Conversation
Member
Author
|
Most of that was written with LLM help, though I did a lot of fixing things up because it's never quite right 😅. |
This allows overriding some cronjobs to stop them from running. Also adds a `system.listCronjobs()` command to show the runtime state.
The genStrongholds is a good example; if it ever rejects, it takes out the entire backend process because of an uncaught rejection.
Member
Author
|
Fixed a couple issues with restarts not having the config read yet, leading to disabled cronjobs having a chance at running. |
AlinaNova21
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new service, adding a
cronjobMgrsection to the config file whose keys are cronjob names and values are eithertrue,falseor a number, overriding the cronjob's default state.The idea is that if you don't want strongholds, or deposits, just set
genStrongholds: false,getDeposits: falsewhich would stop the server from processing those jobs. There's also a newsystem.listCronjobs()cli command to check on the state of everything.Included is a small fix to the way we do config block comparisons, as the previous system would just have triggered the event every time because of the equality check used. Instead, do a deep comparison so we only update configs if there are different.