Conversation
Address security issues identified by code scanning: 1. Added integrity and crossorigin attributes to the jQuery script to prevent potential supply chain attacks 2. Fixed regex in getParameterByName function to properly escape backslash characters This PR improves the security of the strikes page that was fixed in PR # 70.
Closed
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Author
|
This PR addresses security issues identified by GitHub's code scanning after PR #70 was merged. Security improvements:
These changes don't affect functionality but improve the security posture of the page. |
mcgdj
reviewed
Apr 22, 2025
Collaborator
mcgdj
left a comment
There was a problem hiding this comment.
Great; that fixed the JS error for me.
Contributor
Author
|
Thank you for reviewing and merging this security fix! Glad to hear the JavaScript error is resolved. The strikes page should now be both functional and secure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address security issues identified by code scanning:
This PR improves the security of the strikes page that was fixed in PR #70.
🤖 See my steps and cost here ✨