Skip to content

fix: correct replay defense status logic and test isolation#1932

Open
createkr wants to merge 1 commit intoScottcjn:mainfrom
createkr:fix/issue2640-replay-defense-status-logic
Open

fix: correct replay defense status logic and test isolation#1932
createkr wants to merge 1 commit intoScottcjn:mainfrom
createkr:fix/issue2640-replay-defense-status-logic

Conversation

@createkr
Copy link
Copy Markdown
Contributor

This PR fixes the replay defense logic issues behind rustchain-bounties#2640.

What is included:

  • correct replay-defense status handling for nonce collision and related cases
  • dynamic database path resolution at call time instead of import-time caching
  • replay-defense test isolation fixes so the targeted replay test suite can run together cleanly
  • updated replay-related tests and a concise verification note

Validation performed:

python3 -m pytest tests/test_replay_defense.py tests/test_replay_defense_standalone.py tests/test_replay_bounty.py tests/test_fingerprint_replay.py tests/test_signed_transfer_replay.py --tb=short

Result:

  • 74 passed
  • 0 failed

RTC payout wallet: RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35

@github-actions github-actions bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related tests Test suite changes size/M PR: 51-200 lines labels Mar 28, 2026
@Scottcjn
Copy link
Copy Markdown
Owner

@createkr — Bounty #2640 was already fulfilled by #1951, but your fix has additional improvements to the replay defense logic (26 line changes to hardware_fingerprint_replay.py). Would you like to resubmit as a follow-up fix PR? We'll review and pay for the incremental improvements separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) documentation Improvements or additions to documentation node Node server related size/M PR: 51-200 lines tests Test suite changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants