Downgrade: raise OrdinaryDiffEqNonlinearSolve floor to 1.15#471
Merged
ChrisRackauckas merged 1 commit intoJun 28, 2026
Merged
Conversation
The Downgrade (lts) lane fails at precompile with:
MethodError: no method matching init(::NonlinearProblem,
::NonlinearSolveFirstOrder.GeneralizedFirstOrderAlgorithm;
abstol, verbose)
OrdinaryDiffEqNonlinearSolve's compat floor of "1" lets the downgrade
resolver pick 1.14.1, which pulls NonlinearSolve 4.10.0. NonlinearSolve
4.10's loose compat (NonlinearSolveBase = "1.4.0 - 1",
NonlinearSolveFirstOrder = "1.2.0 - 1") permits the inconsistent pair
NonlinearSolveFirstOrder 1.7.0 + NonlinearSolveBase 1.14.0. The
init(::AbstractNonlinearProblem, ::AbstractNonlinearSolveAlgorithm)
method NonlinearSolveFirstOrder relies on only exists from
NonlinearSolveBase 1.15.0 onward (NonlinearSolveFirstOrder 1.8 bumped its
own floor to 1.15.0 for exactly this reason), so the pair fails to
precompile.
OrdinaryDiffEqNonlinearSolve 1.15 requires NonlinearSolve "4.12.0 - 4",
which requires NonlinearSolveBase "2", eliminating the broken option.
Verified on Julia 1.10 LTS by running the real julia-downgrade-compat@v2
action against the patched Project.toml: it resolves a consistent set
(OrdinaryDiffEqNonlinearSolve 1.15.0, NonlinearSolve 4.12.0,
NonlinearSolveBase 2.2.0, NonlinearSolveFirstOrder 1.11.1) and the full
test environment precompiles cleanly.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore this PR until reviewed by @ChrisRackauckas.
Problem
The
Downgrade(lts) lane fails at precompile:(seen reding
OrdinaryDiffEqSDIRK/OrdinaryDiffEqNonlinearSolve/NonlinearSolveprecompilation).Root cause
OrdinaryDiffEqNonlinearSolve's compat floor of"1"lets the downgrade resolver pick 1.14.1, which pulls NonlinearSolve 4.10.0. NonlinearSolve 4.10's loose compat (NonlinearSolveBase = "1.4.0 - 1",NonlinearSolveFirstOrder = "1.2.0 - 1") permits the internally inconsistent pair:NonlinearSolveFirstOrder 1.7.0+NonlinearSolveBase 1.14.0The
init(::AbstractNonlinearProblem, ::AbstractNonlinearSolveAlgorithm)method thatNonlinearSolveFirstOrderrelies on only exists fromNonlinearSolveBase1.15.0 onward —NonlinearSolveFirstOrder 1.8bumped its ownNonlinearSolveBasefloor to1.15.0for exactly this reason. With the downgrade-resolvedNonlinearSolveBase 1.14.0, that method is absent, so precompile dies.Fix
Raise the floor to
OrdinaryDiffEqNonlinearSolve = "1.15, 2". ODENLS 1.15 requiresNonlinearSolve "4.12.0 - 4"→NonlinearSolveBase "2", which eliminates the broken combination.OrdinaryDiffEqNonlinearSolveis a test-only dep (used solely forNLNewtonintest/isothermal_compressible.jl), andNLNewtonis stable across the bumped range.Verification
Ran the real
julia-actions/julia-downgrade-compat@v2action (mode=deps,julia=lts) against the patchedProject.tomlon Julia 1.10.11, then instantiated and precompiled the resulting manifest:OrdinaryDiffEqNonlinearSolve 1.15.0,NonlinearSolve 4.12.0,NonlinearSolveBase 2.2.0,NonlinearSolveFirstOrder 1.11.1.ModelingToolkitStandardLibrary+ the OrdinaryDiffEq/NonlinearSolve stack) precompiled cleanly — theMethodErroris gone.Note / out of scope
This fixes the precompile blocker on the Downgrade lane. The
Downgrade.ymlcomment about being "expected RED until the fntype regression (#458/#452) is resolved" refers to Core test failures introduced by newer ModelingToolkit (11.25+). Under downgrade the resolver pins MTK to its floor (11.0.0), which predates that regression, so those failures should not trigger here — but this PR is scoped to the NonlinearSolve precompile floor and does not attempt to address the fntype-regression tracking items.🤖 Generated with Claude Code