Canonical CI: grouped-tests.yml + root test/test_groups.toml#462
Merged
ChrisRackauckas merged 1 commit intoJun 8, 2026
Merged
Conversation
Convert the root Tests.yml test workflow into a thin caller of the
canonical SciML/.github grouped-tests.yml@v1 reusable workflow, with the
group x version matrix declared once in test/test_groups.toml.
The previous workflow hand-maintained a {version: [1, lts, pre]} x
{group: [Core, QA]} matrix calling tests.yml@v1. That matrix now lives in
test/test_groups.toml (Core and QA each on ["1", "lts", "pre"]) and is
computed by compute_affected_sublibraries.jl --root-matrix.
runtests.jl already dispatches on the standard GROUP env var (Core/QA), so
no group-env-name input is needed and no runtests.jl change is required.
No check-bounds/coverage/apt-packages overrides were used by the old job,
so the thin caller carries no `with:` inputs. on: triggers and concurrency
are preserved verbatim; name: "Tests" is kept so branch-protection status
checks remain valid. All other workflow files are untouched.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root Tests.yml test workflow into a thin caller of the canonical
SciML/.githubgrouped-tests.yml@v1 reusable workflow, with the package's group × version matrix declared once in a roottest/test_groups.toml.Before
Tests.ymlhand-maintained a matrix{version: ["1","lts","pre"]} × {group: ["Core","QA"]}(6 jobs) callingtests.yml@v1directly.After
test/test_groups.toml:Tests.ymlbecomes a thin caller:Why no
with:inputsruntests.jlalready dispatches on the standardGROUPenv var (Core/QA) — nogroup-env-nameoverride needed, and noruntests.jlchange is required.check-bounds,coverage,coverage-directories, orapt-packagesoverrides, so the thin caller carries nowith:block (all defaults match the old behavior).osfield (defaults toubuntu-latest), matching the original.Preserved
name: "Tests",on:triggers, andconcurrency:are kept verbatim so branch-protection status checks remain valid.Matrix match
Ran
compute_affected_sublibraries.jl . --root-matrixagainst the newtest/test_groups.toml; it emits exactly the 6 cells the old workflow produced:All runners
ubuntu-latest,continue_on_error=false(no non-fatal group like Downstream is in this root matrix — Downstream is a separate workflow). 6/6 exact match.QA
Category A — Core/QA
GROUPdispatch already existed inruntests.jl; static matrix-verification only (no local Aqua run needed).test_groups.tomlparses as valid TOML andTests.ymlparses as valid YAML.Ignore until reviewed by @ChrisRackauckas.