Skip to content

Optimizations, closes #1070#1071

Open
Teranis wants to merge 68 commits into
mainfrom
optimizations
Open

Optimizations, closes #1070#1071
Teranis wants to merge 68 commits into
mainfrom
optimizations

Conversation

@Teranis
Copy link
Copy Markdown
Member

@Teranis Teranis commented Apr 7, 2026

  • updated RP to
    • Cache centroids
    • Estimate centroids based on bbox if exact is not important
    • Ability to update only the cutout of the entire lab (GUI can use bbox of "old" obj before change, current view or custom bbox
      • handles border touching correctly (ignore if specific IDs are provided and not part of it, otherwise label them with mask)
    • Apply assignment changes (Just ID swaps, for example, from tracker) and avoid recomputing RP altogether
    • Apply deletions (similar to assignments)
  • updated CellACDC trackers to
    • return assignments for real-time tracking
    • Handle tracking for only a subset of IDs inside the tracker itself
  • updated GUI:
    • Integration of new RP functionality
    • Left some comments to review together with @ElpadoCan
    • Updated swapping and assigning IDs to use RP (merge safe!)
    • Clear border uses its own implementation
    • Set Lost centroids now look for the closest pixel with the correct ID
    • Loading optimisation from acdc_df (minor, but nice for 3D)
    • Segm metadata, loading of data if applicable
  • Updated debugutils to have a line benchmark decorator for nice execution time stats
  • Drawing missing IDs now uses bulk, significant speedup and memory save for many new obj

Questions:
Is update_rp always called? Also, when modifying unvisited frames?

Teranis and others added 27 commits April 6, 2026 20:16
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
@Teranis Teranis marked this pull request as ready for review April 27, 2026 17:54
@Teranis Teranis requested review from ElpadoCan and Copilot April 27, 2026 17:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 39 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cellacdc/trackers/CellACDC/CellACDC_tracker.py
Comment thread cellacdc/regionprops.py
Comment thread cellacdc/regionprops.py
Comment thread cellacdc/load.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants