DEV-183 Dev Toolbar#852
Closed
ryanechternacht wants to merge 8 commits into
Closed
Conversation
Closed
…olbar package Move DeveloperToolbar class out of the JS package into a new toolbar/ package so it can be installed as a devDependency and never bundled into production. The JS package now uses a dynamic import() to discover the toolbar at runtime, falling back to a console.error if not installed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add vitest infrastructure to toolbar/ (config, setup, tsconfig, eslint) - Add 22 unit tests for DeveloperToolbar class (initialize, cleanup, overrides) - Add 11 integration tests to js/ for SDK toolbar integration points - Add pull_request_toolbar.yml CI workflow (build/lint/test on PRs) - Add deploy_toolbar.yml CI workflow (publish to npm on tag) - Update publish-package.sh and release_candidate.yml to include toolbar Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ryanechternacht
force-pushed
the
toolbar-take-2
branch
from
143a57c to
0620cde
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…arDependencies locally Removes js/src/schematic-dev-toolbar.d.ts which caused api-extractor to trace source .ts files through its imports, failing with ae-wrong-input-file-type. Replaces the stub with an inline type cast on the dynamic import. Defines DeveloperToolbarDependencies locally in the toolbar package so it does not depend on the unpublished type from @schematichq/schematic-js@1.3.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
see #1064 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/schematic/issue/DEV-183/add-a-dev-toolbar
https://www.loom.com/share/47adb5985bcc4143b753027beb66e09b
this was a bit of flyer that I (and claude) whipped up. I added a dev toolbar to the core js repo that can be enabled in either js, react, or vue sdks. the one downside of this is that I'm using vanilla js to create/control the toolbar, which is a bit verbose and annoying to read. I refactored the whole toolbar out to it's own file and tried to keep the "logical" parts of the toolbar separate from the "html generation" parts for readability.
currently, the toolbar lets you manually set flag values (either true/false) to simplify testing.
moving forward, I envision 2 big additions
setting numbers for effective entitlements (requires effective entitlements)
setting trial status and other fields in useSchematicPlan hook (requires useSchematicPlan hook)
also, the styling on this is quite simple. happy to edit as we see fit.