Skip to content

Conversation

@zakrzewow
Copy link
Contributor

No description provided.

@Quba1
Copy link
Member

Quba1 commented Jan 7, 2026

Thank you for your contribution!

Version 0.8 of this crate introduced a slightly different structure of projection constructor, which allows to define optional parameters. Would you be able to adapt your code to this new style?

Also, may I ask you to:

  1. Mention in the projection documentation alternative names of this projection (namely that it is sometimes called Rotated Pole).
  2. Clearly indicate in the documentation that the output units of the project function are degrees (in contrast to other projections in this crate, which output meters).

Many thanks!

@zakrzewow
Copy link
Contributor Author

I've adjusted the oblique lon lat transformation implementation to version 0.8. Also, I've clarified the docs.
Please let me know if I should change anything else

Copy link
Member

@Quba1 Quba1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Quba1 Quba1 merged commit 8ceb91b into ScaleWeather:main Jan 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants