Contributions: clarify requirements to PRs#351
Open
RobertMueller2 wants to merge 2 commits into
Open
Conversation
RobertMueller2
force-pushed
the
refresh_contributing
branch
2 times, most recently
from
bbe88c8 to
21e93c3
Compare
gabm
reviewed
Dec 1, 2025
gabm
left a comment
gabm
left a comment
Member
There was a problem hiding this comment.
like it, maybe add the git command?
RobertMueller2
force-pushed
the
refresh_contributing
branch
2 times, most recently
from
3b38795 to
d0aac46
Compare
Member
Author
|
RobertMueller2
force-pushed
the
refresh_contributing
branch
3 times, most recently
from
e2a9653 to
3157483
Compare
RobertMueller2
force-pushed
the
refresh_contributing
branch
3 times, most recently
from
08ba183 to
6ceca8b
Compare
RobertMueller2
force-pushed
the
refresh_contributing
branch
from
6ceca8b to
3f409fb
Compare
RobertMueller2
force-pushed
the
refresh_contributing
branch
from
3f409fb to
fadf967
Compare
robertwidfen
reviewed
Jun 4, 2026
robertwidfen
left a comment
robertwidfen
left a comment
Collaborator
There was a problem hiding this comment.
I would prefer a more template like structure maybe even with sections - but I am not much into this so far ...
| @@ -0,0 +1,26 @@ | |||
| <!-- | |||
Collaborator
There was a problem hiding this comment.
Should this really be a comment?
Member
Author
There was a problem hiding this comment.
This started as a friendly pointer to Contributing.md that had no business being displayed in the PR text. But it might have evolved beyond that. Need to reconsider here :)
|
|
||
| tl;dr: | ||
|
|
||
| - please make sure all commits compile |
Collaborator
There was a problem hiding this comment.
I would prefer a checklist:
- all commits compile
- all commits use conventional commit messages
- (re)based onto main
- includes breaking changes
- includes LLM/Generative AI code
- I vouch for the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.