Skip to content

fix: dyn-compatibility precision#30

Merged
SaschaOnTour merged 2 commits into
mainfrom
fix/livetime-bug
May 26, 2026
Merged

fix: dyn-compatibility precision#30
SaschaOnTour merged 2 commits into
mainfrom
fix/livetime-bug

Conversation

@SaschaOnTour

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 26, 2026 22:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves dyn-compatibility precision for the trait-contract must_be_object_safe analyzer by allowing method-level lifetime generics while continuing to flag type and const generics.

Changes:

  • Refines object-safety generic detection with a new helper that only flags type/const method generics.
  • Adds regression tests for lifetime-generic methods and const-generic methods.
  • Bumps the crate version to 1.2.6 and updates changelog release notes.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/adapters/analyzers/architecture/trait_contract_rule/checks.rs Updates object-safety logic and finding message.
src/adapters/analyzers/architecture/tests/trait_contract.rs Adds regression coverage for lifetime and const generics.
CHANGELOG.md Adds 1.2.6 release notes and dates prior releases.
Cargo.toml Bumps package version to 1.2.6.
Cargo.lock Updates locked package version to 1.2.6.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 26, 2026 22:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

@SaschaOnTour SaschaOnTour merged commit 2be545b into main May 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants