Open
Conversation
Add 'simple-recipe-pro' class
moving this out to a const sets up a central definition that can be reused in multiple code paths when generating the recipe overlay. smittenkitchen, for example, has recipes in multiple <p> tags and would require a code path that clones more than one node.
Move controls to a const string literal
implement #13: remove jQuery
Some websites overlay the entire page with a consent dialog (example: https://www.simplyrecipes.com/recipes/tomatillo_salsa_verde/) that opens on top of the recipe overlay. Closing this dialog by accepting/declining causes the recipe overlay to close as well which effectively makes it unusable in those pages.
Don't close recipe overlay on consent approval
Fix issue where modal was clickable after being closed
* fix: don't try foreach an empty array * chore: restructure the manifest to V3 There wasn't any big changes necessary, mostly renaming keys. Google's [conversion tool](https://developer.chrome.com/blog/extension-manifest-converter) did all the work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I absolutely love this extension but the one you made for firefox has bugs that have been fixed by the original extension. Is it possible for you to keep it synced? I'm open to doing some work to figure out how to merge the branches if you're unwilling.