refactor: replace symlinks with file copy#24
Merged
Conversation
Removed platform-specific symlink logic (Windows junction vs. dir symlinks) and replaced with cross-platform fs.cpSync and fs.copyFileSync operations. Simplifies code by eliminating isWindows detection and related helper functions (ensureDir, symlink, linkDir, linkFiles). Updated messaging from "Linking to" to "Copying to". Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Replaces symlink logic in the
aiworkers setupcommand with direct file/directory copying. Since AIWorkers is now an npm package installed globally, symlinks pointing back to the package directory are unnecessary — copying is simpler and works the same on all platforms without special handling.Type of change
📝 Changes
bin/commands/setup.js— removedisWindows,ensureDir,symlink,linkDir,linkFiles. Replaced withcopyDir(fs.cpSyncrecursive) andcopyFiles(fs.copyFileSync). Cross-platform by default.🧪 Testing
🎟️ Related Tickets