Skip to content

feat: implement outbound fiat transfer API#495

Open
GiftedGiftB wants to merge 1 commit into
SafeVault:mainfrom
GiftedGiftB:InitiateFiatBankTransferAPI
Open

feat: implement outbound fiat transfer API#495
GiftedGiftB wants to merge 1 commit into
SafeVault:mainfrom
GiftedGiftB:InitiateFiatBankTransferAPI

Conversation

@GiftedGiftB
Copy link
Copy Markdown

closed #483

Pull Request

Summary

Fixed backend test failures and validation bugs across time-off, KYB, 2FA verify, and token refresh flows. Updated request validation and JWT service usage to match expected test behavior.

Type of Change

  • Feature
  • Bug Fix
  • Refactoring
  • Documentation
  • Tests
  • Infrastructure / CI

Linked Issues

Key Changes

  • Relaxed employeeId validation in time-off.schema.ts so admin time-off submissions accept non-UUID identifiers.
  • Normalized KYB missing-path errors in route.ts to use "Validation failed" for required document validation failures.
  • Added missing await calls in route.ts for token generation.
  • Updated token-refresh.service.ts to use the correct JWT verification and token issuance helpers.
  • Verified targeted suites and type checking:
    • route.test.ts
    • route.test.ts
    • route.test.ts
    • token-refresh.service.spec.ts
    • pnpm exec tsc --noEmit --pretty false

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new linting/type-checking warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the documentation accordingly.

Screenshots / Recordings

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

@GiftedGiftB is attempting to deploy a commit to the vestroll's projects Team on Vercel.

A member of the Team first needs to authorize it.

@codeZe-us
Copy link
Copy Markdown
Contributor

@GiftedGiftB PR should point to dev branch not main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Initiate Fiat Bank Transfer API

2 participants