Open
Conversation
…iption to a lot of functions and methods.
…ready in there would be appended to the file once more
…ugh having a "return" without any type; fixed a bug where attributes would not have a type even though a type is defined the docstrings
…ion would wrongly be labeled as TypeVarType
…d a few bugs regarding the reexport check
…sections of docstrings will be merged now
…ng's with logging.info; various fixes
…or the loaded griffe data instead of parsing through it every time we search for a specific docstring
…e stub generator, which probably takes about O(n^3) right now.
…docstring-runtime
# Conflicts: # src/safeds_stubgen/api_analyzer/_ast_visitor.py # src/safeds_stubgen/docstring_parsing/_docstring_parser.py # src/safeds_stubgen/stubs_generator/_stub_string_generator.py
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 26 26
Lines 2616 2618 +2
=======================================
+ Hits 2612 2614 +2
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lars-reimann
requested changes
Mar 7, 2025
Member
lars-reimann
left a comment
There was a problem hiding this comment.
Unfortunately, this breaks the generation of imports.
Previously, the following import was created:
from safeds.ml.classical.classification import Classifier
Now it is this:
from classifier import Classifier
9c8de70 to
2a3cb09
Compare
Contributor
Author
|
@lars-reimann, should be fixed now. Please have a look and tell me if there's still something wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Big libraries like PyTorch had a runtime of about 20-30 Minutes, which was because of unoptimized code in the
_check_publicity_in_reexports()function. Now the runtime takes about ~2 minutes for PyTorch.Either merge this branch into the
various_fixesbranch or mergevarious_fixesintomainfirst, followed by this branch.Summary of Changes
_check_publicity_in_reexports()code, which has a runtime of O(n³)